Bug fixes for working with .PGNs that contain FEN position tags.#58
Merged
CorentinGS merged 4 commits intoCorentinGS:mainfrom Jul 12, 2025
Merged
Bug fixes for working with .PGNs that contain FEN position tags.#58CorentinGS merged 4 commits intoCorentinGS:mainfrom
CorentinGS merged 4 commits intoCorentinGS:mainfrom
Conversation
When parsing a game which includes both a FEN position tag and variations, parseVariation() should use the rootMove's position rather than assume the starting position.
When a Game is constructed from a .pgn containing a FEN, the parsed moves may not begin at move 1. Similarly, the player to move cannot be assumed to be white. This commit fixes both by using the rootMove's position to determine both the initial move number to output and the turn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on replacing notnil/chess with corentings/chess in mikeb26/chesstools I ran into a handful of bugs related to .PGNs containing FEN position tags. These 3 bug fixes address the issues I found.